Pull Request for Added Devices

I’ve done a lot of looking around, and I can’t find instructions on how to create a pull request after adding a device. Can anyone point me in the right direction?

@Koenkk has put together a page that describes the process here:

I used it recently to add an LED bulb. It does assume a little knowledge of using GIT (which I didn’t have, but managed to work it all out).

I should have documented my experience, but I was just thankful that it all worked! I forked the development branch modified that and created a pull request. I had to follow about 4 different GIT guides because as I said my GIT knowledge is very much newbie level.

But I was successful and I did see my submission in the latest Z2M version.

If you need any more info I’ll see if I can find the guides I used and put together a step by step.


I managed to stumble through it, with a few question marks:

  1. Fork this repository:

  2. Clone it to your local machine.

  3. Create a branch to work in.

  4. Make your changes to devices.js

  5. Add and commit your changes with “git add .”

  6. You should now see the files you changed with “git status”

  7. Now commit your changes with a note, like so:
    git commit -m “Added Sinope TH1300ZB as new device”

  8. Then push your changes:
    git push origin sinopeTH1300ZB

  9. This is where things broke down for me a bit as a complete git novice. There will be a message in the commit log on your console, giving you a URL. Copy/Paste that into your browser and you’ll find the pull request process:

remote: Create a pull request for ‘sinopeTH1300ZB’ on GitHub by visiting:
remote: https://github.com//zigbee-herdsman-converters/pull/new/sinopeTH1300ZB

I had assumed that I would be able to see the branch I just pushed to my git account, but couldn’t find a way other than this to see it. I’m sure it’s a knowledge gap on my part.